Fix MML #1429: MegaMek side of fix for MML NPE in Aero Equipment tab #5176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SJuliez
approved these changes
Feb 18, 2024
In that case the base maxRange value is returned. |
This was referenced Feb 19, 2024
SJuliez
approved these changes
Feb 20, 2024
|
I have the NPE but I am unsure how to apply the fix for the dropship/small craft equipment tab. Please advise, thank you. |
The fix is checked in to the development branch, so your options as of right now are:
If you decide to go with option 1, please come over to the MegaMek discord so we can help get you up and running; it's not quite as easy as playing with the current release version (from what I recall). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the MM fix for MegaMek/megameklab#1429; what I thought was a guard check against weapon being
nullwas actually a form of overloading that's used exclusively by the megameklab UI to select AV range bands when displaying equipment.I've created a bare getter that returns the value that UI builder needs, and added a check to call it if the weapon passed to
wtype.getRanges()is null.Testing:
I'd like to add a unit test to MegaMekLab to make sure that this doesn't regress but I need some help on that, so for now this should be sufficient.
Close MegaMek/megameklab#1429